feat: add live plugin json validation - #32
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds “live” validation feedback for plugin JSON configs in the plugin editor drawer, so users can see JSON syntax + semantic config issues before attempting to save, with an accompanying E2E assertion.
Changes:
- Watch the JSON editor field and compute live validation results (syntax, schema, AI Gateway, compatibility) when on the JSON tab.
- Render a compact warning
Alertthat summarizes validation issues and shows up to 5 inline items. - Extend the plugin metadata E2E to confirm invalid JSON shows the new “Fix JSON syntax before saving.” warning prior to clicking “Add Plugin”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/form-slice/FormItemPlugins/PluginEditorDrawer.tsx | Adds watched JSON editor validation + capped warning summary UI in the plugin drawer. |
| e2e/tests/plugin_metadata.crud-all-fields.spec.ts | Adds an assertion that the new pre-save JSON syntax warning appears for invalid JSON. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+305
to
+311
| const jsonValidation = useMemo(() => { | ||
| if (activeTab !== 'json' || mode === 'view') return null; | ||
|
|
||
| let parsed: unknown; | ||
| try { | ||
| parsed = JSON.parse(jsonConfigText || '{}'); | ||
| } catch (error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification